search

tghamm / dynamic-linq-query-builder

A truly generic and dynamic linq query builder to compliment jQuery QueryBuilder and other dynamic linq query generation needs
MIT License
262 stars 110 forks source link

Add Plugin_Config again #103

Closed TheUltimateC0der closed 1 year ago

TheUltimateC0der commented 2 years ago

I have searched for a way to configure plugins, but havent found a way to do so.

I stumled upon a commit a few years ago (https://github.com/tghamm/dynamic-linq-query-builder/commit/2285ed710fa4d44a8ef8f9efd9894a19d599003d), where Plugin_config has been removed.

I would love to see it added again, since people are currently unable to configure their plugins.

tghamm commented 2 years ago

Hi @TheUltimateC0der per the commit notes, it seems that the consensus was that the plugin object was just too messy/complicated, and that the builder included in this library is pretty simplistic. Would it not make more sense to define your schema client-side as the commit suggests? I could be convinced to bring it back, but this does seem like covered ground a little bit. Let me know your thoughts!

TheUltimateC0der commented 2 years ago

I define everything in code, since I use this code at some other places to make my life easier. Having to define it in JS and my code forces me to take care of both things instead of just one.

tghamm commented 1 year ago

@TheUltimateC0der this will be added back in #112 apologies for the delay.