tghamm / dynamic-linq-query-builder

A truly generic and dynamic linq query builder to compliment jQuery QueryBuilder and other dynamic linq query generation needs
MIT License
262 stars 110 forks source link

Added toggle to enable case sensitive comparisons #108

Closed Ilanlido closed 1 year ago

Ilanlido commented 1 year ago

Fixed object comparison bugs by converting to string Updated dictionary access reflaction to use Get_Item instead of Index (mongo driver supports only Get_Item)

Ilanlido commented 1 year ago

Need to add more support for object comparisons

tghamm commented 1 year ago

Is your use case here against a MongoDB? If so, mind providing some details on a basic implementation? I'm not a Mongo user but would be interested in adding a few integration tests if that's the target destination the same way I targeted EFCore just to make sure I could test locally that changes aren't breaking for either driver user.

Ilanlido commented 1 year ago

Yes, The dictionary support is mainly for mongo. You're right, ill take a look at what you did with EFCore to add more tests. Thanks for the fast responses!! Highly appreciated :)

Ilanlido commented 1 year ago

@tghamm Regarding mongo tests, how do you prefer to do it? Local tests like you did with sql server? or use something like https://github.com/Mongo2Go/Mongo2Go ?

tghamm commented 1 year ago

@Ilanlido Yeah I can set up a local instance to match if you setup the buildup/teardown, the way I did it with SQL seems to make the most sense, just so it's against a real db instance. I found at least with SQL, the in memory/fake dbs had different behaviors that were only exposed when I hit a real db, so I always run those tests before an actual publish.

Ilanlido commented 1 year ago

@tghamm Understood, is it possible to merge these PRs and i'll add a local test for mongo in the weekend? Thanks!

tghamm commented 1 year ago

@Ilanlido yeah, all 3 ready to go? Thanks!

Ilanlido commented 1 year ago

Yes, thank you!