search

tgockel / zookeeper-cpp

A ZooKeeper client for C++.
http://tgockel.github.io/zookeeper-cpp/
Apache License 2.0
148 stars 40 forks source link

remove zk::client::client default constructor declaration as it is no… #110

Closed Jauler closed 4 years ago

Jauler commented 4 years ago

Hey,

zk::client::client default constructor was declared, but never defined. This might cause a bit confusing "undefined reference" errors during linking.

I was also thinking about defaulting this constructor (= default), but then any called method will try to dereference empty shared_ptr (_conn), so in my opinion, it is better just to delete the declaration.

Jauler commented 4 years ago

I accidentally used my work email for commit author, so I force pushed the same commit to correct that.