Fix FlowAddress and FlowId ByteArray size

kaliweh-circle commented 3 years ago

Description

This PR pads the bytes of the FlowId and FlowAddress classes when an instance is created using the constructor methods (similar to the of(bytes: ByteArray) implementation).

For contributor use:

[x] Targeted PR against master branch
[x] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[x] Code follows the standards mentioned here.
[x] Updated relevant documentation
[x] Re-reviewed Files changed in the Github PR explorer
[x] Added appropriate labels

kaliweh-circle commented 3 years ago

cc: @briandilley. Thank you!

jereanon commented 3 years ago

Looks good to me.

github-actions[bot] commented 3 years ago

Unit Test Results

  6 files ±0   6 suites ±0 22s :stopwatch: ±0s 29 tests ±0 29 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0

Results for commit fde2f979. ± Comparison against base commit fde2f979.

the-nft-company / flow-jvm-sdk

Fix FlowAddress and FlowId ByteArray size #1

Description

Unit Test Results