Add TypeField and TypeValue

the-nft-company / flow-jvm-sdk

Apache License 2.0

13 stars 25 forks source link

Add TypeField and TypeValue #4

Closed kaliweh-circle closed 2 years ago

kaliweh-circle commented 2 years ago

Closes: #3

Description

Add the json-cadence TypeField and TypeValue.

For contributor use:

[x] Targeted PR against master branch
[X] Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
[X] Code follows the standards mentioned here.
[X] Updated relevant documentation
[X] Re-reviewed Files changed in the Github PR explorer
[X] Added appropriate labels

kaliweh-circle commented 2 years ago

flow-go-sdk equivalent functionality here flow cadence docs for the Type value [https://docs.onflow.org/cadence/json-cadence-spec/#type]

briandilley commented 2 years ago

Looks good, merging it into main. Should show up in the next SNAPSHOT release in about 10 minutes after the merge. We don't have a regular release schedule for this SDK yet so it may be a couple of weeks before it makes it into the release version.

github-actions[bot] commented 2 years ago

Unit Test Results

  8 files ±0   8 suites ±0 29s :stopwatch: ±0s 32 tests ±0 32 :heavy_check_mark: ±0 0 :zzz: ±0 0 :x: ±0

Results for commit 78b6f2ed. ± Comparison against base commit 78b6f2ed.

kaliweh-circle commented 2 years ago

Thank you @briandilley 🙏