theBenForce / logseq-plugin-my-highlights

Import highlights from various sources
MIT License
36 stars 4 forks source link

Import highlights not working #19

Closed thelazyoxymoron closed 2 years ago

thelazyoxymoron commented 2 years ago

Logseq version: 0.7.5 plugin version: 1.16.0

Clicking on "Load Clippings File" opens up the file picker, but no action afterwards when the selection is done.

petrushy commented 2 years ago

Can confirm this bug on both linux & windows, logseq: 0.7.9

theBenForce commented 2 years ago

I'm able to reproduce now, so hopefully I can get it fixed.

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 1.16.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

Gitbreast commented 2 years ago

@theBenForce Problem's still there. Even have tried reload, reinstall the plugin, turn off other plugins. Here's the gif: Logseq_bALSMc630S

Plus: The plugin was worked early before(when I first time install), so that maybe could rule out the file system problem(where I storage the MyClipping.txt)and even the format recognize problem? Just in case, here's a screenshot about the format inside my clipping flie. Though it's in Chinese it should be has no difference with English version. image

theBenForce commented 2 years ago

@Gitbreast could you share a few highlights from your clippings file? That may help me reproduce the issue.

Gitbreast commented 2 years ago

@theBenForce Sure! Here's the end part of my clippings. My Clippings part.txt How I got this file is: I copy the original file from my KP3, then delete about 9/10 of it, then ctrl+s and rename. So that avoid changing the encode or something like that. BTW now it's this: image

theBenForce commented 2 years ago

Thank you! I found the issue, it's because I'm looking for markers like "Location" and "Added on". I'll try to come up with a more robust way of parsing the metadata, but for now I'll just make sure it can parse without finding the metadata.

theBenForce commented 2 years ago

It's not getting all of the metadata, but the next release will pull your highlights in!

image
github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 1.16.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: