fix: import highlights from language other than english

theBenForce / logseq-plugin-my-highlights

Import highlights from various sources

MIT License

36 stars 4 forks source link

fix: import highlights from language other than english #28

Closed theBenForce closed 2 years ago

theBenForce commented 2 years ago

Resolves #19 by not requiring all metadata to be found. Will need to revisit in the future and figure out how to reliably parse metadata that isn't stored in english.

Testing

Works on sample provided by @Gitbreast

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.16.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

Gitbreast commented 2 years ago

@theBenForce Thanks for the work! I will check the latest version later! Perhaps could recognize by different rows and the “|” vertical bar? or in the setting, let the user define the recognize method through define the keyword or the Regular expression or something like that. For now it’s ok for me, after all, the page number in kindle would change with the font size changing, so I rarely use it. Haha.

theBenForce commented 2 years ago

It's already splitting up the rows, fortunately that doesn't change.

The problem with parsing based on the pipe | is their can be different items listed on that line.

I'll try to get it setup so that you can edit the labels in settings, that's a good idea!

Gitbreast commented 2 years ago

@theBenForce That’s nice! Just take it slow. Wait for your good news;)