search

thebylito / react-native-navigation-bar-color

React Native component to change bottom bar/navigation bar color on Android
MIT License
271 stars 50 forks source link

Updated android SDK version to 28 #13

Closed maximilize closed 5 years ago

maximilize commented 5 years ago

Fixes a compile error when doing a release build with react-native 0.59.

I ran into this error:

> Task :react-native-navigation-bar-color:verifyReleaseResources FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':react-native-navigation-bar-color:verifyReleaseResources'.
> java.util.concurrent.ExecutionException: com.android.builder.internal.aapt.v2.Aapt2Exception: Android resource linking failed
  project/node_modules/react-native-navigation-bar-color/android/build/intermediates/res/merged/release/values-v28/values-v28.xml:7: error: resource android:attr/dialogCornerRadius not found.
  project/node_modules/react-native-navigation-bar-color/android/build/intermediates/res/merged/release/values-v28/values-v28.xml:11: error: resource android:attr/dialogCornerRadius not found.
  project/node_modules/react-native-navigation-bar-color/android/build/intermediates/res/merged/release/values/values.xml:2714: error: resource android:attr/fontVariationSettings not found.
  project/node_modules/react-native-navigation-bar-color/android/build/intermediates/res/merged/release/values/values.xml:2715: error: resource android:attr/ttcIndex not found.
  error: failed linking references.
notmike101 commented 5 years ago

Before I merge, if you can, please confirm that everything still works as expected on < Android 9?

notmike101 commented 5 years ago

@maximilize Did you get a chance to confirm?

micheltosu commented 5 years ago

I did the same change in my android/build.gradle file as the PR suggests and it workes just fine afterwards.