search

thecointech / thecoin

Mono-repo for TheCoin project
https://thecoin.io
GNU Affero General Public License v3.0
3 stars 1 forks source link

Resolve circular dependency shared > storybookutils -> shared #515

Open FrozenKiwi opened 5 months ago

FrozenKiwi commented 5 months ago

Currently shared does not build/typecheck stories.

shared stories use storybookutils for withStore etc, however storybookutils provides helpers that use components from shared:

import { buildAccountStoreReducer, AccountMapState, AccountMap } from '@thecointech/shared/containers/AccountMap';

Result: shared stories & tests are not type-checked.

To fix: extract to common base packages (shared needs to be split up anyway)