search

theendsofinvention / esst

MIT License
4 stars 0 forks source link

super minor issue: -wx only works when you specifiy -n also #77

Open 132nd-Entropy opened 5 years ago

132nd-Entropy commented 5 years ago

super minor issue only, but the discord bot doesnt give a warning when you load a mission by using !mission load -wx ICAO instead of !mission load -n x -wx ICAO.

theendsofinvention commented 5 years ago

That's not expected.

Without specifying a mission, it should reload the current one with new weather.

I'm shelving this one for the next iteration.

Thank you for reporting !

132nd-Entropy commented 5 years ago

just downloaded your latest release, the fix is working!

132nd-Entropy commented 5 years ago

build 2018.11.14.1-300-dbddfad0926ea5248a88cba7d4acf211580120 however spams error messages when you go !dcs status

132nd-Entropy commented 5 years ago

just tested, this bug only apprears when you go !dcs status after loading the mission with !mission load -wx ICAO or !mission load -n x -wx ICAO.

If you load without -wx ICAO then you wont see the bug and !dcs status works, apparently

132nd-Entropy commented 5 years ago

now the error messages are gone but I get this report when using !dcs status from a mission that was hosted with -wx ICAO: 


> Dcs application: running
> Dcs cpu usage: 21%
> Dcs version: 2.5.3.23954
> Metar: Weather(source='UGKO', source_type='ICAO', _station_icao='UGKO', station_name='Kopitnari Airport', raw_metar_str='UGKO 141430Z 25006KT 9999 BKN048 10/09 Q1017 NOSIG', metar_data=MetarData(raw='UGKO 141430Z 25006KT 9999 BKN048 10/09 Q1017 NOSIG', remarks='NOSIG', station='UGKO', time=Timestamp(repr='141430Z', dt=datetime.datetime(2018, 11, 14, 14, 30)), altimeter=Number(repr='1017', value=1017, spoken='one zero one seven'), clouds=[Cloud(repr='BKN048', type='BKN', altitude=48, modifier=None)], flight_rules='VFR', other=[], sanitized='UGKO 141430Z 25006KT 9999 BKN048 10/09 Q1017 NOSIG', visibility=Number(repr='9999', value=9999, spoken='nine nine nine nine'), wind_direction=Number(repr='250', value=250, spoken='two five zero'), wind_gust=None, wind_speed=Number(repr='06', value=6, spoken='six'), dewpoint=Number(repr='09', value=9, spoken='nine'), remarks_info=RemarksData(dewpoint_decimal=None, temperature_decimal=None), runway_visibility=[], temperature=Number(repr='10', value=10, spoken='one zero'), wind_variable_direction=[]), metar_units=Units(altimeter='hPa', altitude='ft', temperature='C', visibility='m', wind_speed='kt'), altimeter=Pressure(762.8126226350325, "mmhg"), cloud_layers=[Cloud(repr='BKN048', type='BKN', altitude=48, modifier=None)], visibility=Visibility(9999.0, "m"), temperature=Temperature(10, "c"), dew_point=Temperature(9, "c"), wind_speed=WindSpeed(3.0866666666666744, "m/s"), wind_direction=WindDirection(250.0, "degrees"), wind_direction_range=[], wind_gust=WindSpeed(0.0, "m/s"), date_time=Timestamp(repr='141430Z', dt=datetime.datetime(2018, 11, 14, 14, 30)), other=[], remarks='NOSIG', wind_direction_is_variable=False, original_dcs_weather=None)
> Mission file: C:/Users/132nd/Saved Games/DCS.openbeta/Missions/ESST/AUTO/TRM_2.1.1.miz
> Mission name: TRM_2.1.1
> Mission time: 2 hours ago
> Paused: False
> Players: []
> Server age: 2 hours ago
> Server status: loaded mission
theendsofinvention commented 5 years ago

If the issue is the METAR format, then it is a placeholder for the time being (resulting from the transition to my own weather parsing library). I will not fix this before the next iteration of ESST, as it is mainly eye-candy and does not hamper main functionality.

If, however, there is something else wrong, please let me know!

theendsofinvention commented 5 years ago

@132nd-Entropy Can this be closed ?