theinze / pyrate

Optical raytracing based on Python
GNU General Public License v2.0
1 stars 0 forks source link

Comment on quickcheck failure of material tests #7

Open joha2 opened 7 years ago

joha2 commented 7 years ago

Just a comment: During the tests of the matrix constructions for the anisotropic materials, there are still some constraints on the different quantities appearing in those equations:

The violation of these constraints leads to problems:

I would suggest to let rnd_data1, rnd_data2, rnd_data3 be chosen in the specified ranges (i.e. [0.1, 1)). But rnd_data4 and rnd_data5 can be chosen from [0,1). If the last choice leads to problems, these maybe real bugs.