Open ilibarra opened 1 year ago
@ege-erdogan may you please indicate to me where mb.tl.combine_h5
is and/or merge it to development if ready? The last task can be separated, I suppose.
@ilibarra Sorry for the late response; pushed to the model-aggregation
branch now (https://github.com/theislab/mubind/blob/model-aggregation/mubind/tl/aggregation.py).
Model layers are appended to a new (empty) model and activations/etas are summed right now, but changing what is done during aggregation is straightforward in the implementation.
Next necessary features
mb.get.binding_modes()
that takes the already loaded from h5 files, and results in a list of binding modes. The input can be a h5_path/multibind instance, or list of h5_paths/multibind instances. h5 and multibind instances can be mixed.mb.tl.concatenate
, that returns a single multibind instance from the combine_h5 and get.binding_modes.@ege-erdogan please feel free to use snippets from these scripts for faster understanding/implementation of intermediate steps. https://github.com/theislab/mubind/blob/development/notebooks/concatenation/01_load_and_concatenate.ipynb
majorly solved by #108
Reopening due to test_aggregation.py not working. It needs inspection.
into mubind/tl/aggregation.py
mb.tl.combine_h5
to load and merge BindingModes from h5 files into single MultiBind classes with all those concatenated.mb.get.binding_modes()
that takes the already loaded from h5 files, and results in a list of binding modes. The input can be a h5_path/multibind instance, or list of h5_paths/multibind instances. h5 and multibind instances can be mixed.mb.tl.concatenate
, that returns a single multibind instance from the combine_h5 and get.binding_modes.