theislab / mubind

Learning motif contributions to cell transitions using sequence features and graphs.
https://mubind.readthedocs.io
MIT License
26 stars 0 forks source link

aggregation of filters/activities/etas into unified MultiBind instance #102

Open ilibarra opened 1 year ago

ilibarra commented 1 year ago

into mubind/tl/aggregation.py

ilibarra commented 1 year ago

@ege-erdogan may you please indicate to me where mb.tl.combine_h5 is and/or merge it to development if ready? The last task can be separated, I suppose.

ege-erdogan commented 1 year ago

@ilibarra Sorry for the late response; pushed to the model-aggregation branch now (https://github.com/theislab/mubind/blob/model-aggregation/mubind/tl/aggregation.py).

Model layers are appended to a new (empty) model and activations/etas are summed right now, but changing what is done during aggregation is straightforward in the implementation.

ilibarra commented 1 year ago

Next necessary features

ilibarra commented 1 year ago

@ege-erdogan please feel free to use snippets from these scripts for faster understanding/implementation of intermediate steps. https://github.com/theislab/mubind/blob/development/notebooks/concatenation/01_load_and_concatenate.ipynb

ilibarra commented 1 year ago

majorly solved by #108

ilibarra commented 1 year ago

Reopening due to test_aggregation.py not working. It needs inspection.