search

theislab / scib-reproducibility

Additional code and analysis from the single-cell integration benchmarking project
https://theislab.github.io/scib-reproducibility/
MIT License
53 stars 13 forks source link

update metrics files for RNA #16

Closed martaint closed 2 years ago

martaint commented 2 years ago

Hi @mumichae ! Finally everything worked out :)

lazappi commented 2 years ago

@martaint I think this looks good. Only thought I have is that I also have the metrics files in the data/ directory for building the website. Not sure if maybe it's worth removing one of them (unless one of us has messed up they should be identical).

martaint commented 2 years ago

Hi @lazappi, uhm I see! Maybe it's not worth it though...the thing is that we specifically refer to the metrics files in the README, so removing them would probably be confusing for the readers (in the visualization folder). In the end, it's just repeated info, no? But at least it's logically organized...

lazappi commented 2 years ago

I mostly agree, I think that's why I didn't clean it up earlier 😸.

lazappi commented 2 years ago

@martaint I assume you double-checked that nothing in the README refers to the files that are being deleted?

martaint commented 2 years ago

Yes exactly, I changed the README as well! :D