themerdev / themer

🎨 themer takes a set of colors and generates themes for your apps (editors, terminals, wallpapers, and more).
https://themer.dev
MIT License
5.52k stars 117 forks source link

Implementation of Warp Theme Generator #140

Closed trbndev closed 2 years ago

trbndev commented 2 years ago

This pull requests implements a theme generator for Warp based on the Slack implementation.

Generated Files

Two files will be generated, one for a light and one for a dark theme. Theme Files will be generated in the following format: themer_(Theme Name)_(dark | light).yaml e.g. themer_colors-default_dark.yaml

Example File Output with colors-default

Screenshot of themer_colors-default_dark.yaml

(Permalink of output)

Tests

Theme generator tested

(Permalink of output)

colors-default applied to Application

Bildschirmfoto 2022-08-14 um 14 36 56
netlify[bot] commented 2 years ago

Deploy request for themer-dev rejected.

Name Link
Latest commit 5a9b9d321cf0149fe15e843d28113303484da820
mjswensen commented 2 years ago

This is fantastic, @trbnhck , thank you so much for this!

mjswensen commented 2 years ago

I will get this published on npm and on themer.dev as soon as possible and will keep you updated here 👍

trbndev commented 2 years ago

Thank you very much :)!

mjswensen commented 2 years ago

OK @trbnhck , this is now available on npm at @themerdev/warp as well as the web UI at themer.dev 🎉

I had to make a slight change: your original implementation included the color set name in the outputted file, but this won't work for users who define their own custom color sets (because there would be no name). However, I see the value in being able to differentiate between themer-generated themes so I've logged an issue at #141 to start thinking about how to add that support generally across all of themer's tools.

In the meantime, when you are copying themes from themer's output folder to ~/.warp/themes, you can rename them at that point, as a temporary workaround:

mv /tmp/themer-output/warp/themer_dark.yml ~/.warp/themes/themer_default_dark.yml # for example

Thank you again for this! 🙏

trbndev commented 2 years ago

Thank you for fixing that!