search

themerdev / themer

🎨 themer takes a set of colors and generates themes for your apps (editors, terminals, wallpapers, and more).
https://themer.dev
MIT License
5.52k stars 117 forks source link

Hack for gray conversion should no longer be necessary #89

Closed spenserblack closed 1 year ago

spenserblack commented 3 years ago

Description

For the vim theme, there is currently a hack that uses Euclidean distance to get color conversions. With https://github.com/Qix-/color-convert/pull/75 merged, the next release of color-convert should make this calculation unnecessary. It should be able to be replaced with a simple convert.hex.ansi256(hexVal).

Also, doing so will fix a bug I introduced in that hack (it converts colors 0-254 instead of 0-255 due to < 255 instead of <= 255) 😥

This should be a good issue for any first-time contributors!