themix-project / themix-gui

Graphical application for generating different color variations of Oomox (Numix-based) and Materia (ex-Flat-Plat) themes (GTK2, GTK3, Cinnamon, GNOME, Openbox, Xfwm), Archdroid, Gnome-Color, Numix, Papirus and Suru++ icon themes. Have a hack for HiDPI in gtk2. Its Base16 plugin also allowing a lot of app themes support like Alacritty, Emacs, GTK4, KDE, VIM and many more.
GNU General Public License v3.0
2.08k stars 67 forks source link

Extend oomox compatibility to other custom themes? #94

Closed Warmuser closed 6 years ago

Warmuser commented 7 years ago

There are many interesting themes to customize, could be possibile to extend the oomox compatibility with other custom themes like:

Let me know if it possible, thanks! :)

actionless commented 7 years ago

yes, it's possible (in the same way how now icon theme is being selected) i will be happy to merge to oomox pull requests with any new themes

Warmuser commented 7 years ago

Ok thanks, anyway I want to add also Vimix (Numix variant) to the request, because its a really valid and complete theme. :)

actionless commented 7 years ago

btw i forgot to mention what it won't be possible for any themes which are using any bitmap image assets (they first should be replaced to SVG)

Warmuser commented 7 years ago

Ok, I opened some compatibility requests for oomox. :)

actionless commented 7 years ago

thanks! please mention me with an @ if it will be needed any my input in those conversations

Warmuser commented 7 years ago

Ok :)

actionless commented 7 years ago

Flat-Plat is ready, all other which you listed quite similar to it, except for arc-theme, i personally like arc and vertex themes

Warmuser commented 7 years ago

Fantastic! Thank you @actionless and @nana-4 :) , anyway I have some problems to update with pamac. I will try a fresh installation of omox and flat-pat. :)

This is the log:

Synchronizing package databases... Starting full system upgrade...

Preparing...

Building oomox-git... Cloning into 'oomox-git'... remote: Counting objects: 204, done.
remote: Compressing objects: 100% (170/170), done.
remote: Total 204 (delta 69), reused 143 (delta 33)
Receiving objects: 100% (204/204), 35.46 KiB | 3.22 MiB/s, done. Resolving deltas: 100% (69/69), done. ==> Making package: oomox-git 1.3.0-2 (Mon Aug 28 18:20:11 CEST 2017) ==> Checking runtime dependencies... ==> Checking buildtime dependencies... ==> Retrieving sources... -> Cloning oomox git repo... Cloning into bare repository '/tmp/pamac-build-manjaro/oomox-git/oomox'... remote: Counting objects: 15192, done.
remote: Compressing objects: 100% (17/17), done.
remote: Total 15192 (delta 2), reused 12 (delta 1), pack-reused 15174
Receiving objects: 100% (15192/15192), 8.72 MiB | 1.51 MiB/s, done. Resolving deltas: 100% (8231/8231), done. -> Cloning oomox-gtk-theme git repo... Cloning into bare repository '/tmp/pamac-build-manjaro/oomox-git/oomox-gtk-theme'... remote: Counting objects: 14014, done.
remote: Total 14014 (delta 0), reused 0 (delta 0), pack-reused 14014
Receiving objects: 100% (14014/14014), 8.84 MiB | 1.12 MiB/s, done. Resolving deltas: 100% (7587/7587), done. -> Cloning Flat-Plat git repo... Cloning into bare repository '/tmp/pamac-build-manjaro/oomox-git/Flat-Plat'... remote: Counting objects: 9525, done.
remote: Total 9525 (delta 0), reused 0 (delta 0), pack-reused 9525
Receiving objects: 100% (9525/9525), 29.26 MiB | 1.47 MiB/s, done. Resolving deltas: 100% (5890/5890), done. ==> Validating source files with md5sums... oomox ... Skipped oomox-gtk-theme ... Skipped Flat-Plat ... Skipped ==> Extracting sources... -> Creating working copy of oomox git repo... Cloning into 'oomox'... done. Switched to a new branch 'makepkg' -> Creating working copy of oomox-gtk-theme git repo... Cloning into 'oomox-gtk-theme'... done. Switched to a new branch 'makepkg' -> Creating working copy of Flat-Plat git repo... Cloning into 'Flat-Plat'... done. Switched to a new branch 'makepkg' ==> Starting prepare()... Submodule 'flat-plat-theme' (https://github.com/nana-4/Flat-Plat.git) registered for path 'flat-plat-theme' Submodule 'gtk-theme' (git@github.com:actionless/oomox-gtk-theme.git) registered for path 'gtk-theme' Cloning into '/tmp/pamac-build-manjaro/oomox-git/src/oomox/flat-plat-theme'... Cloning into '/tmp/pamac-build-manjaro/oomox-git/src/oomox/gtk-theme'... The authenticity of host 'github.com (192.30.253.112)' can't be established. RSA key fingerprint is SHA256:nThbg6kXUpJWGl7E1IGOCspRomTxdCARLviKw6E5SY8. Are you sure you want to continue connecting (yes/no)? y Please type 'yes' or 'no': yes Warning: Permanently added 'github.com,192.30.253.112' (RSA) to the list of known hosts. Permission denied (publickey). fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists. fatal: clone of 'git@github.com:actionless/oomox-gtk-theme.git' into submodule path '/tmp/pamac-build-manjaro/oomox-git/src/oomox/gtk-theme' failed Failed to clone 'gtk-theme'. Retry scheduled Cloning into '/tmp/pamac-build-manjaro/oomox-git/src/oomox/gtk-theme'... Warning: Permanently added the RSA host key for IP address '192.30.253.113' to the list of known hosts. Permission denied (publickey). fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists. fatal: clone of 'git@github.com:actionless/oomox-gtk-theme.git' into submodule path '/tmp/pamac-build-manjaro/oomox-git/src/oomox/gtk-theme' failed Failed to clone 'gtk-theme' a second time, aborting ==> ERROR: A failure occurred in prepare(). Aborting...

actionless commented 7 years ago

submodule names need to be updated in PKGBUILD, now it should work fine

untoreh commented 6 years ago

the materia theme style does not allow menu/toolbar text, is that a limitation of the theme itself? Because the effective menu/toolbar text color is inherited from the background color and not even from the foreground/text color

actionless commented 6 years ago

sorta, in original theme those colors are the same as well, i can later on add an option to switch between using such pattern as currently (as in normal Materia theme) and using the same colors as normal background (as in Materia-Light theme)

actionless commented 6 years ago

since there was no feedback from other themes' devs i think this can be closed by now

untoreh commented 6 years ago

I think right click menus have the same problem

actionless commented 6 years ago

@untoreh i've reported that issue already: https://github.com/nana-4/materia-theme/issues/183#issuecomment-348741654

actionless commented 6 years ago

@untoreh fixed in c69a336

untoreh commented 6 years ago

menu is fixed, however menubar background now has selection highlight color

actionless commented 6 years ago

@untoreh please try with 3849cc48021b45fcaabfbe12a0fc312f22e65c1b