theochem / gbasis

Python library for analytical evaluation and integration of Gaussian-type basis functions and related quantities.
http://gbasis.qcdevs.org/
GNU Lesser General Public License v3.0
40 stars 22 forks source link

[REQUEST] Make lincint wrapper more flexible #178

Closed FarnazH closed 7 months ago

FarnazH commented 7 months ago

Is there a change to the code or algorithm you would like to see? In the libcint wrapper:

These two items can be addressed in separate PRs.

msricher commented 7 months ago

The first one is implemented and is in the code right now.

leila-pujal commented 7 months ago

Maybe I am totally mistaken because sometimes with the Libcint class some things slip, but for the electron_repulsion here I was expecting and argument to pass what notation to choose so here it is choose based on what is passed. Maybe I am wrong and you can actually pass the argument already. If so, if you could add an example here that would be really helpful. Let me know what you think.

FarnazH commented 7 months ago

@msricher, I am confused too, and cannot take a closer look right now. You are right that the notation argument is supported, but it is not accessible when calling the electron_repulsion_integral as @leila-pujal mentioned.

Can you please give an example of how electron repulsion integrals can be computed with "chemists" notation?

msricher commented 7 months ago

Oh, that's right! I forgot to make the argument accessible with the user-facing functions. I will do that. Thank you both.

leila-pujal commented 7 months ago

No worries! Thanks a lot

leila-pujal commented 7 months ago

Do you think you can add this to PR #180 ?