theosanderson / gensplore

Lightweight genome browser for microbial genomes
https://gensplore.theo.io
8 stars 1 forks source link

Refactor nucleotide search highlighting logic #31

Closed sweep-ai[bot] closed 1 year ago

sweep-ai[bot] commented 1 year ago

Description

This PR refactors the nucleotide search highlighting logic in the SingleRow component to use the same logic as the sequence search highlighting. Currently, the nucleotide search uses a custom tick implementation for highlighting, which is inconsistent with the sequence search highlighting. This PR removes the custom tick implementation and modifies the logic for generating searchTick and sequenceHitRects to work with both nucleotide and sequence search. The intSearchInput prop is no longer needed and is removed from the SingleRow component.

Summary of Changes

Please review and merge these changes. They ensure consistency in highlighting across different types of search.

Fixes #28.


To checkout this PR branch, run the following command in your terminal:

git checkout sweep/refactor-nucleotide-search-highlighting

To make tweaks to this pull request, leave a comment below or in the code.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
genbank-view ❌ Failed (Inspect) Aug 3, 2023 10:40pm