German Translation

[peat80]

Describe the solution you'd like...

I would like to know if this project would accept translations.

I could translate the strings of this app into german language. But it would be wasted time if it will not get accepted. So the question is would you merge such a pr?

Thanks for your hard work making this great app. It is a must have for me on android tv. 😍

[theothernt]

Yes, I'd be happy to accept translations - it's something that's been on the TODO list for quite a while!

Plus, I haven't got around to updating the README about contributions, etc.

Do you have experience creating the language resources for an Android app or do you need my help to set it up?

Also, as the app is still under development, I might need new translations or updates in the the future if you're able to help.

[peat80]

Okay that is cool. I will make a german translation when i have the time and then try to do a pull request when ready. If strings change in the future or new strings will be added i will try to keep german strings up to date in the future. 😀👌

[theothernt]

That sounds great - thank you!

And just in case you need it, here is the official user guide on how to translate text resources in an Android app.

[peat80]

Please have a look at #53 if this is okay. Have done this with a normal text editor on phone cause i have no android studio.

[theothernt]

Give me a day or two to look at it 👍🏻

[theothernt]

A friend just had a quick look and suggested a couple of changes - let me know what you think?

After that, we should be good to merge!

[theothernt]

v1.2.2 is finally out which includes the German translation. I've added a small credit in the release notes but I do hope to add all contributors to the README at some point!

Also, I did find some hard-coded text strings that are not in the strings.xml ... so I may contact you soon about that 😅

[peat80]

Have installed the update now. 😃👌 There are just are a few bits untranslated. If you add them to the strings.xml in the future we (or i) will get them translated for sure. 😎

[theothernt]

I might ask you to take a look at some of the English -> German strings again in the next week or so as I hope to add all the remaining app text into localisable strings.

[peat80]

Sure, sounds good. 😎

[theothernt]

Thanks for that update @peat80. I still have more text changes to make but I think I'll just ship the current update (soon) as-is.

[theothernt]

Sorry to ask again, but if you have some free time, there are a load of new text strings in the app due to a complete re-organisation of the menus. Big changes to the text should be very rare! 😅

[peat80]

Sure, i will have a look. Have already installed the new version yesterday. Great update btw. 😎👌

Should have time to look at the new strings in a few days. 😀

[peat80]

Finished updating the strings.

[theothernt]

Thanks again for updating the translation - I'm hoping to add the remaining strings into resource files soon-ish.

[theothernt]

Quick question for you - do you know what happens when a language is requested (eg. German) but there is no text or resource for that language, does it default to English?

[theothernt]

Ah, I think I see it now - it helps to look at the filesystem and not the file list in Android Studio.

/values and /raw are the default so if openrawresource() is called and the file for the current locale doesn't exist, I think strings.xml or values.xml is returned and not /values-de/strings.xml

[theothernt]

If you have some free time, would you be interested in translating the POIs for the new Community videos?

[peat80]

Where is that file located? 🤔

[theothernt]

Where is that file located? 🤔

Here you go...

comm1_strings.json

comm2_strings.json

Also, the language can be switched in the latest build for testing.

[peat80]

Is see. Maybe i can find the time to do this over the weekend. 🤔 😀

[peat80]

Translations should be up to date again. Hope we can see them in a new release soon. 😃

[theothernt]

Translations should be up to date again. Hope we can see them in a new release soon. 😃

Thank you so much! I'm hoping to have that update out in the next week or so.

[theothernt]

I've added a few more new strings that need translation when you have some spare time?

[peat80]

I'll try to have a look at it soon.

[theothernt]

I'll try to have a look at it soon.

Thank you once again for your help with the translation 🥳

[theothernt]

when you have time, there are 10 new videos in the comm2_strings.json that need translation?

(you can ignore the app strings for the moment as more changes are coming in the next release so I might ping you in a few weeks about them)

[peat80]

Added the missing video strings.

Will do app strings after you say they are ready. 😀

[theothernt]

Added the missing video strings.

Will do app strings after you say they are ready. 😀

Thanks again, I'm hoping to add a lot more text in 1.5.2 🥳

[theothernt]

Ok, I've finally added all (I think?) text from the app into resources - and it's ready to be translated when you have time :)

[peat80]

Added latest translations. Did not check if already translated strings were changed. I have only translated the new english ones.

Also noticed that the string appearance_date_custom_example looks wrongly formatted.

[theothernt]

Added latest translations. Did not check if already translated strings were changed. I have only translated the new english ones.

Also noticed that the string appearance_date_custom_example looks wrongly formatted.

Thanks for the translations.

I removed the "// for example" comment, the text is supposed to be "e.g." though.

[theothernt]

Dang, looks like I forgot to include the Capabilities screen strings.

EDIT: Ok, strings have been copied into other languages.

[peat80]

Completed (probably)... 🙊🙈🙉

[theothernt]

Thanks again - if you notice any strings that I missed, let me know :)

[theothernt]

Not translation related, but it looks like there are a couple of bugs in v1.6. I've found the following so far...

• If location is disabled, when you update to v1.6 - the screensaver will crash
• the upper and lower slots are in the wrong order

If you happen to notice anything else, do let me know. I'll probably release an update next week depending on how many crash reports I get (only 1 affected user so far)

[peat80]

I've noticed there are a couple of strings in settings / appearance that do use english strings instead of translated ones. Other than that it seems to work fine here. 😀👌

[theothernt]

Ah good, I'll fix those things 😅

[theothernt]

I've noticed there are a couple of strings in settings / appearance that do use english strings instead of translated ones. Other than that it seems to work fine here. 😀👌

Ok, fixed two issues...

1. I forgot to copy some resources into de/array.xml ?!
2. Translations were not used on the "Date format" dropdown

[peat80]

Translations should be ready now for the next update. 😀👌

[theothernt]

Ok, that update is live with all the fixes 😅

[theothernt]

There are two new sentences in next update, when you have time?

[peat80]

A little too late 4 release it seems... 🤣👌

[theothernt]

A little too late 4 release it seems... 🤣👌

Apologies! I should have messaged you earlier, but at least it's only a couple of items 😅

[theothernt]

I've just changed and added some more text. No hurry, I won't be releasing this update for another week or so 😅

Also, I was given access to Lokalise platform for translations. If you'd like to use it, let me know - although if PRs are easier, please stick with that.

And, as always, thank you so much for all the help you've given!

[peat80]

Never tried that platform, but that could eventually be more comfortable for tranlations than github. 🧐😀

[peat80]

Translations should be updated now.

[theothernt]

Never tried that platform, but that could eventually be more comfortable for tranlations than github. 🧐😀

I just need an email address, then I can send on an invite...

[peat80]

peat01@gmx.net

[theothernt]

Would you have some time for translation update on Lokalise? No problem at all if you don't have free time!