search

theowenyoung / gatsby-theme-primer-wiki

A Gatsby Theme for Wiki/Docs/Knowledge Base, which using Primer style as the UI theme, can work well with Foam or Obsibian or just markdown files.
https://demo-wiki.owenyoung.com/
MIT License
117 stars 18 forks source link

max width for content page #42

Closed dfeng closed 2 years ago

dfeng commented 2 years ago

Hello, it's me again. Happy holidays!

I'm looking to add a parameter contentMaxWidth so that I can tweak the max width of the content. It's currently hard-coded as 960px, which is a little too wide for my liking.

I haven't tested this PR (not really sure how to test...).

theowenyoung commented 2 years ago

Well, Thanks for the pr!

If you want to test your feature, just run npm start, it will run the example.

And I noticed the content max-width only affects the main content width, which means it only affects the one column of there columns.

is this your intent?

theowenyoung commented 2 years ago

I've changed the max content width to apply the right two columns, with a default 1440 size.

dfeng commented 2 years ago

I assumed the sidebar on the right was fixed width, so changing the middle column would suffice. This works too!

If you want to test your feature, just run npm start, it will run the example.

Thanks, good to know!