search

thewh1teagle / rookie

Load cookies from your web browsers
https://crates.io/crates/rookie
MIT License
185 stars 17 forks source link

[Bug]: Python docstring issue #46

Closed shner-elmo closed 6 days ago

shner-elmo commented 3 months ago

What happened?

Really cool library overall, but I think I stumbled into a documentation error. The arguments don't seem to match with the error.

image

Other than that, rookiepy.chrome(['...']) and rookiepy.load(['...']) are working fine.

Also, is this a feature or a bug lol? (seems like there is not commit hash for this) image

Steps to reproduce

python 3.11.4 rookiepy 0.5.2() ubuntu

call rookiepy.any_browser() and pass a list of strings

What browsers are you seeing the problem on?

No response

Relevant log output

No response

thewh1teagle commented 3 months ago

Hey! Thanks for report. It seems that the type hints are wrong. the function accept more parameters

https://github.com/thewh1teagle/rookie/blob/78c292cafb9d8ecc5a09f093834d3c0a15594866/bindings/node/src/lib.rs#L44-L48

You may want to use instead the function load()

shner-elmo commented 3 months ago

Got it. Would love to submit a PR with the changes reflecting what is defined in lib.rs