thewh1teagle / rookie

Load cookies from your web browsers
https://crates.io/crates/rookie
MIT License
207 stars 18 forks source link

[Bug]: Load doesnt return cookies from all browsers with the domain. #48

Closed techtanic closed 2 months ago

techtanic commented 2 months ago

What happened?

Python rookiepy.load(["www.web.com"]) returns empty. Looks like it doesnt check all the browsers, and just return from the first browser it finds. Make it instead get all the supported browsers and find the matching domain cookies from all browser.

Maybe also make it check the default browser first.

Steps to reproduce

Installed browsers:firefox, edge, arc Only arc has Cookies.

import rookiepy

c1 = len(rookiepy.load(["www.udemy.com"]))
c2 = len(rookiepy.arc(["www.udemy.com"]))

print("Load:", c1)
print("Arc:", c2)

"""Output:
Load: 0
Arc: 29
"""

What browsers are you seeing the problem on?

No response

Relevant log output

No response

thewh1teagle commented 2 months ago

@techtanic

Thanks for report! I forgot to add arc browser to load function.

https://github.com/thewh1teagle/rookie/blob/main/rookie-rs/src/lib.rs#L368

techtanic commented 2 months ago

Ahh makes sense, Would be appreciated of you could push out an update.

thewh1teagle commented 2 months ago

Published new version

pip install rookiepy==0.5.3b0

Let me know if it works

techtanic commented 2 months ago

It works perfectly! I really appreciate it.