thisbeyond / solid-select

The Select component for Solid.
https://solid-select.com
MIT License
172 stars 18 forks source link

CreateOptions forced filterable to true #30

Closed Lastofthefirst closed 1 year ago

Lastofthefirst commented 1 year ago

When I created options with props = createOptions(value, {key:"speaker", filterable:false}) then included them with {...props} the component still acts as if filterable. Only way I found to prevent this was to stop using createOptions.

martinpengellyphillips commented 1 year ago

I'm not able to recreate that. Passing filterable: false works as expected in my test.

solid-select-disable-filterable

Lastofthefirst commented 1 year ago

Oh yes, this is the same result I am getting, I thought filterable would disable the select as a text input. How do you do that?

martinpengellyphillips commented 1 year ago

Use the readonly prop on the Select.

Lastofthefirst commented 1 year ago

Ah, thats what I was looking for then. Please forgive the false alarm. Thank you for sharing your code and your time 😁