use generics instead of `any` in Option&Value

thisbeyond / solid-select

The Select component for Solid.

https://solid-select.com

MIT License

172 stars 18 forks source link

use generics instead of `any` in Option&Value #44

Closed AlexErrant closed 2 months ago

AlexErrant commented 1 year ago

Apologies for the somewhat large PR; I couldn't figure out how to make it smaller.

AlexErrant commented 1 year ago

Uh, please be aware I haven't tested anything; I just made the raison d'être changes and then fixed all the squigglies.

martinpengellyphillips commented 2 months ago

Looking at this again...I'm not sure the raison d'être is actually desired. It is valid to return from optionToValue values of different types, because format can be used to handle that nicely. Unless I've misunderstood something - it has been a while since I looked at this :)