thisbeyond / solid-select

The Select component for Solid.
https://solid-select.com
MIT License
172 stars 18 forks source link

Fix typings #51

Closed nbaum closed 2 months ago

nbaum commented 6 months ago

Fixes, for me, the TypeScript error:

Could not find a declaration file for module '@thisbeyond/solid-select'. '<project>/node_modules/@thisbeyond/solid-select/dist/esm/index.js' implicitly has an 'any' type.
  There are types at '<project>/node_modules/@thisbeyond/solid-select/dist/types/index.d.ts', but this result could not be resolved when respecting package.json "exports". The '@thisbeyond/solid-select' library may need to update its package.json or typings.

May fix #50 generally, but I don't understand TypeScript well enough to be sure this this is a sufficient fix in all situations.

bonsilapra commented 3 months ago

It works for me too! Please merge this change

naseerdev commented 3 months ago

Please merge this branch.

martinpengellyphillips commented 2 months ago

Possibly superseded by 3587a34

martinpengellyphillips commented 2 months ago

Release 0.15.0 has now been published which should address this. Please re-open if not.