thisbeyond / solid-select

The Select component for Solid.
https://solid-select.com
MIT License
172 stars 18 forks source link

ESBuild warning #55

Closed CoWayger closed 2 months ago

CoWayger commented 4 months ago

Hi, this library produces warning in esbuild when importing css just like in example:

[WARNING] Ignoring this import because "node_modules/@thisbeyond/solid-select/dist/esm/style.css" was marked as having no side effects [ignored-bare-import]

Is marking sideEffects good stated in package.json?

Thank you

martinpengellyphillips commented 2 months ago

I presume this is in your code? I'm not sure how the library could produce the warning at it doesn't import the css itself. I find it odd that esbuild culls a css import 🤷

Not sure how I can help without more info / reproducible example, so closing for now.