search

thisbeyond / solid-select

The Select component for Solid.
https://solid-select.com
MIT License
172 stars 18 forks source link

Remove `key` option for `createOptions` #59

Closed martinpengellyphillips closed 2 months ago

martinpengellyphillips commented 2 months ago

With #58 the key option remains as a small convenience (it replaces typing format: value=>value[key]). But it does result in some complexity internally and also potential surprises - e.g. using defaultFormat externally will not give the same result as when it is called by default because internally there is also processing of the key option if supplied.

Consider removing key to keep things simpler long term.

martinpengellyphillips commented 2 months ago

In 44423cfc69890188b2e294c050fe36b37829be57, found a reasonable approach for keeping the key and maintaining consistency / avoiding surprises. So will not pursue this issue now.