thorstenb / odpdown

Generate OpenDocument Presentation (odp) files from markdown
Other
107 stars 18 forks source link

dependency of lxml, seems to be missing. so fix it. #27

Closed netmarkjp closed 9 years ago

netmarkjp commented 9 years ago

Dependency of lxml written in odpdown.egg-info/requires.txt , but not written in requirements.txt and setup.py .

So I add lxml dependency.

regards.

thorstenb commented 9 years ago

That breaks the travis build - and incidentally, is that a transitive dependency from lpod-python per chance? See also https://github.com/thorstenb/odpdown/pull/24

netmarkjp commented 9 years ago

Fix travis. looks work well now.

In my env, pip install -r requirements.txt did not install lxml... :crying_cat_face:

thorstenb commented 9 years ago

Ah thx, nice catch!

netmarkjp commented 9 years ago

thx! :+1:

xrmx commented 9 years ago

The README and setup.py hunk are wrong though, you are adding a dependency for a library you are not directly using. Requirements update should be enough until fixed upstream.