search

thoth-station / document-sync-job

Sync Thoth documents to an S3 API compatible remote
GNU General Public License v3.0
0 stars 5 forks source link

Make repo into a python package and use scripts #40

Closed VannTen closed 2 years ago

VannTen commented 2 years ago

motivated by #37

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please assign harshad16 after the PR has been reviewed. You can assign the PR to them by writing /assign @harshad16 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/thoth-station/document-sync-job/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
VannTen commented 2 years ago

Also, if we then calling the script using python script.py, we will need a deprecation period

VannTen commented 2 years ago

/test pre-commit

goern commented 2 years ago

/test all

sesheta commented 2 years ago

@VannTen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
aicoe-ci/prow/pre-commit a48aa4538f024f4feff4e71b381833ee33214adc link true /test pre-commit

Full PR test history. Your PR dashboard. Please help us and open an issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
VannTen commented 2 years ago

/hold

might do this as part of #37

harshad16 commented 2 years ago

These changes, seems to be in https://github.com/thoth-station/document-sync-job/pull/37 shall we close this?

VannTen commented 2 years ago

Yep, it's fully included

/close

sesheta commented 2 years ago

@VannTen: Closed this PR.

In response to [this](https://github.com/thoth-station/document-sync-job/pull/40#issuecomment-1271203896): >Yep, it's fully included > >/close > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.