search

thoth-station / document-sync-job

Sync Thoth documents to an S3 API compatible remote
GNU General Public License v3.0
0 stars 5 forks source link

:books: Update development and testing details #41

Closed harshad16 closed 1 year ago

harshad16 commented 1 year ago

Update development and testing details Signed-off-by: Harshad Reddy Nalla hnalla@redhat.com

VannTen commented 1 year ago

Can't we also include the smaug instance (destination) directly in the env.template ? Since from the documentation I get that it's intended as some sort of "default test instance".

harshad16 commented 1 year ago

Lets get this in , wdyt @VannTen ?

VannTen commented 1 year ago

Yeah we're good. I think once thoth-station/thoth-application#2647 get merged we could have more precise refs (like linking directly to Credentials section) but no need to hold back this PR. /lgtm

harshad16 commented 1 year ago

/approve

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harshad16

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/document-sync-job/blob/master/OWNERS)~~ [harshad16] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment