search

thoth-station / micropipenv

A lightweight wrapper for pip to support requirements.txt, Pipenv and Poetry lock files or converting them to pip-tools compatible output. Designed for containerized Python applications but not limited to them.
https://pypi.org/project/micropipenv/
GNU Lesser General Public License v3.0
234 stars 25 forks source link

Disable Thot bot (sesheta) on this project #242

Closed frenzymadness closed 1 year ago

frenzymadness commented 2 years ago

I'd like to disable Thot bot (sesheta) on this project. In my opinion, it generates unnecessary comments and does not add any value to my workflows.

@goern what do you think?

goern commented 2 years ago

I'm good with hat, if you could give a little insight what you like/dont like, what you would like to see, etc.

@Gkrumbach07 @mayaCostantini /kind feature /priority critical-urgent /triage accepted

frenzymadness commented 2 years ago

I'm just used to managing my repositories manually. For example, I don't like the auto-closing of issues. Also, every new PR receives an immediate comment from the bot that the issue is not approved, which is obvious for new PRs. Github has its own standard way for approving of PRs and I like it more than the special commands. One last thing is that the comment from the bot in the latest PR says that I should request a review from myself.

mayaCostantini commented 2 years ago

/sig user-experience

goern commented 2 years ago

Hey @frenzymadness I think you are talking about all the Prow activity you see on issues.

wrt to approving PR, the Prow plugin and GitHub are equivalent, you can use one or the other with the same results. so if you like to click approve on the github web UI, feel free, it will also add the 'approved' label. I wonder why you do the additional manual step of merging by yourself, if a PR is approved, the bot will merge it for you ;)

The initial comment of the bot, that a PR needs approval and who is responsible for review/approve might be obvious, but especially to new contributors, it might be helpful.

Nevertheless, if you can not live with these helpers, feel free to work with @Gregory-Pereira to reconfigure Prow for this repo.

Gkrumbach07 commented 2 years ago

any update on this @frenzymadness?

frenzymadness commented 2 years ago

@Gkrumbach07 I still think I don't need the bot here. But I'm not alone anymore so what do you @VannTen think?

VannTen commented 2 years ago

The lifecycle labels and auto-closing should be disabled now for all repos under thoth-station/

Regarding the tide stuff (approved and lgtm labels and automerging) I'd rather keep them, in particular the lgtm (can only be put by someone else than a PR author if I'm correct) works pretty well to be sure to have a least two set of eyes on stuff going into the main branch.

Gkrumbach07 commented 2 years ago

@frenzymadness @VannTen Is there any other actions to be done regrading the Thoth bot on this repo? If not I will close this issue

VannTen commented 1 year ago

The current state should be :

If you're ok with that, we can close.

frenzymadness commented 1 year ago

Okay. I'm closing this now. Thanks to all of you.