search

thoth-station / micropipenv

A lightweight wrapper for pip to support requirements.txt, Pipenv and Poetry lock files or converting them to pip-tools compatible output. Designed for containerized Python applications but not limited to them.
https://pypi.org/project/micropipenv/
GNU Lesser General Public License v3.0
231 stars 25 forks source link

Bump supported pip version #258

Closed VannTen closed 1 year ago

VannTen commented 1 year ago

/approve

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: frenzymadness, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/micropipenv/blob/master/OWNERS)~~ [VannTen,frenzymadness] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
VannTen commented 1 year ago

Prow needs a /lgtm by itself (approved is supposed to be : should we do that ?, lgtm: is it done correctly, for the reason why both labels are required. (and lgtm can't be applied by the author, so that force a least one review by someone else))

sesheta commented 1 year ago

@VannTen: you cannot LGTM your own PR.

In response to [this](https://github.com/thoth-station/micropipenv/pull/258#issuecomment-1422912110): >Prow needs a >/lgtm >by itself >(approved is supposed to be : should we do that ?, lgtm: is it done correctly, for the reason why both labels are required. (and lgtm can't be applied by the author, so that force a least one review by someone else)) > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
goern commented 1 year ago

/lgtm