search

thoth-station / micropipenv

A lightweight wrapper for pip to support requirements.txt, Pipenv and Poetry lock files or converting them to pip-tools compatible output. Designed for containerized Python applications but not limited to them.
https://pypi.org/project/micropipenv/
GNU Lesser General Public License v3.0
231 stars 25 forks source link

Implement support for "url" source type in poetry #264

Closed frenzymadness closed 1 year ago

frenzymadness commented 1 year ago

Fixes: https://github.com/thoth-station/micropipenv/issues/251

This introduces a breaking change

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from frenzymadness by writing /assign @frenzymadness in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/thoth-station/micropipenv/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
VannTen commented 1 year ago

Looks sane to me.

What do you think is missing on the testing side ?

Could you please take a look at the PR and help me with testing?

What do you think is missing in the testing ? Adding for direct-only for example ?

/lgtm

frenzymadness commented 1 year ago

I think that the tests here are enough. What I meant was that the reporter might be able to test the fix with their original reproducer. If not, I'll merge this in a couple of days.