Do not process entries from poetry.lock until their category is known - Githubissues

thoth-station / micropipenv

A lightweight wrapper for pip to support requirements.txt, Pipenv and Poetry lock files or converting them to pip-tools compatible output. Designed for containerized Python applications but not limited to them.

https://pypi.org/project/micropipenv/

GNU Lesser General Public License v3.0

231 stars 25 forks source link

Do not process entries from poetry.lock until their category is known #299

Closed frenzymadness closed 2 weeks ago

frenzymadness commented 1 month ago

Related Issues and Dependencies

https://github.com/thoth-station/micropipenv/issues/295

Let's see what this change will break. I expect possible incompatibility with older poetry.

frenzymadness commented 1 month ago

Now is the time to check the failures and see whether the code is wrong or the test is wrong.

frenzymadness commented 1 month ago

There are two kind of breaking changes now:

Packages are allowed to be in more than one category - the category is either derived from the content of pyproject.toml (for direct dependencies) or from the package with another package as a dependency (to be in the same category).
Because of the previous point, packages might be mentioned more than once in pipfiles (where it make sense) but we do not allow duplicities in requirements files.

frenzymadness commented 1 month ago

It seems that the new test with complex dependencies is not compatible with Python <= 3.7. Fixed.

frenzymadness commented 1 month ago

This is a big change. A review is necessary. Cc: @fridex @yrro

frenzymadness commented 4 weeks ago

Does anybody have a plan to do a review?

fridex commented 4 weeks ago

Does anybody have a plan to do a review?

I had a brief look on changes - it looks like they are well covered by tests. Unfortunately, I don't have time for an in-depth review. Feel free to consider +1 from me. Very nice job and thanks for looking into this! 👍🏻 💯

It would be great if @yrro could verify this patchset on the originally reported issue or provide the related lockfile (if not done already).

yrro commented 3 weeks ago

I think my pyproject.toml and lockfile made it into the tests for this PR. But I hope I can give it a manual test on my proejct some time this week.

frenzymadness commented 3 weeks ago

Thank you both. Sam is correct - his configuration is now part of the tests.

frenzymadness commented 2 weeks ago

Or we can test it out there in the wild with a new release :thinking:

frenzymadness commented 2 weeks ago

All right, let's give it a try.