Changing disable_index_adjustment in Pipfile does not invalidate cache

thoth-station / user-api

Web Service exposing Thoth functions to the RESTful worlds

https://thoth-station.github.io/

GNU General Public License v3.0

8 stars 18 forks source link

Changing disable_index_adjustment in Pipfile does not invalidate cache #1581

Open fridex opened 2 years ago

fridex commented 2 years ago

Describe the bug

Changing disable_index_adjustment does not invalidate cache on user-api.

To Reproduce Steps to reproduce the behavior:

Add dependencies to Pipfile, e.g. thamos add tensorflow --index-url 'https://tensorflow.pypi.thoth-station.ninja/index/manylinux2010/AVX2/simple'
Ask for an advise
Change disable_index_adjustment in Thoth's section of Pipfile
See cached results returned

Expected behavior

Changing index adjustment should differentiate requests to Thoth.

goern commented 2 years ago

/priority important-soon

sesheta commented 2 years ago

Issues go stale after 90d of inactivity. Mark the issue as fresh with /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

harshad16 commented 2 years ago

/lifecycle frozen

goern commented 2 years ago

is this something we still need to fix? pls review!

harshad16 commented 2 years ago

Maybe something discusses and review in the stack guidance sig. I don't think this is addressed yet.

/sig stack-guidance