search

thoth-station / user-api

Web Service exposing Thoth functions to the RESTful worlds
https://thoth-station.github.io/
GNU General Public License v3.0
8 stars 18 forks source link

Downgrade connexion ==2.3.0 #1710

Closed mayaCostantini closed 2 years ago

mayaCostantini commented 2 years ago

Related Issues and Dependencies

Related to #1708

This introduces a breaking change

This should yield a new module release

This Pull Request implements

Downgrade connexion to version 2.3.0 to fix the ImportError from werkzeug. Dependencies were updated using pipenv.

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: To complete the pull request process, please ask for approval from mayacostantini after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/thoth-station/user-api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
harshad16 commented 2 years ago

/deploy

mayaCostantini commented 2 years ago

Thanks for the review @harshad16 I found a combination of dependencies that work locally and added the changes in https://github.com/thoth-station/user-api/pull/1716 Let's close this PR /close

sesheta commented 2 years ago

@mayaCostantini: Closed this PR.

In response to [this](https://github.com/thoth-station/user-api/pull/1710#issuecomment-1066640633): >Thanks for the review @harshad16 >I found a combination of dependencies that work locally and added the changes in https://github.com/thoth-station/user-api/pull/1716 >Let's close this PR >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.