search

thoth-station / user-api

Web Service exposing Thoth functions to the RESTful worlds
https://thoth-station.github.io/
GNU General Public License v3.0
8 stars 18 forks source link

Remove `count` and `limit` from advise endpoint #1726

Closed fridex closed 2 years ago

fridex commented 2 years ago

Is your feature request related to a problem? Please describe.

As per discussion in the tech talk, we could drop these two parameters on the advise endpoint. They should be controlled based on the backend configuration rather than allowing users to supply them to the resolution process.

Describe the solution you'd like

Remove count and limit from the advise endpoint. Also, it would be great to make sure that removing these values does not affect scheduling adviser in a deployment negatively (defaults are properly used).

codificat commented 2 years ago

For context: tech talk recoding is here.

/triage accepted /priority important-longterm /sig user-experience

mayaCostantini commented 2 years ago

/close

sesheta commented 2 years ago

@mayaCostantini: Closing this issue.

In response to [this](https://github.com/thoth-station/user-api/issues/1726#issuecomment-1081962573): >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mayaCostantini commented 2 years ago

Closed by #1727