search

thoth-station / user-api

Web Service exposing Thoth functions to the RESTful worlds
https://thoth-station.github.io/
GNU General Public License v3.0
8 stars 18 forks source link

feat: add callbackurl to advise endpoint #1759

Closed KPostOffice closed 2 years ago

KPostOffice commented 2 years ago

Related Issues and Dependencies

closes: https://github.com/thoth-station/user-api/issues/1756

This introduces a breaking change

This should yield a new module release

This Pull Request implements

Creation of secrets based on document id as well as posting results to webhook if already available.

sesheta commented 2 years ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

goern commented 2 years ago

what is the status of this?

harshad16 commented 2 years ago

/deploy

KPostOffice commented 2 years ago

This should be good to go now.

KPostOffice commented 2 years ago

@harshad16 PTAL

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: harshad16 To complete the pull request process, please assign sesheta after the PR has been reviewed. You can assign the PR to them by writing /assign @sesheta in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/thoth-station/user-api/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
KPostOffice commented 2 years ago

Hmm, not sure who has permissions to merge this