Fix default marker_evaluation_result value in package dependencies endpoint

thoth-station / user-api

Web Service exposing Thoth functions to the RESTful worlds

https://thoth-station.github.io/

GNU General Public License v3.0

8 stars 18 forks source link

Fix default marker_evaluation_result value in package dependencies endpoint #1760

Closed mayaCostantini closed 2 years ago

mayaCostantini commented 2 years ago

This introduces a breaking change

This should yield a new module release

This Pull Request implements

The marker_evaluation_result default value in the /python/package/dependencies endpoint should be set to null instead of false. Otherwise, this causes the following error:

"error": "Operating system and Python interpreter version need to be specified to obtain dependencies dependent on marker evaluation result"

for any value of marker_evaluation_result.

sesheta commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fridex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/user-api/blob/master/OWNERS)~~ [fridex] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment