thoth-station / user-api

Web Service exposing Thoth functions to the RESTful worlds
https://thoth-station.github.io/
GNU General Public License v3.0
8 stars 18 forks source link

Invalid default values for some endpoints #1766

Closed mayaCostantini closed 2 years ago

mayaCostantini commented 2 years ago

Describe the bug

Some API endpoints have default values that result in 40 errors, empty values returned with 20 status code or the API crashing probably because of exceptions not handled in the API logic. This could cause issues for users wanting to try the API with those default values but also later for security tests we would like to have.

To Reproduce

Go to the API on stage / prod environments and execute API requests on those endpoints (for example some /python/package/... endpoints).

Expected behavior

Non-empty values are returned with a 20* status code.

Proposed solution

mayaCostantini commented 2 years ago

/priority critical-urgent /sig user-experience

harshad16 commented 2 years ago

/triage accepted /assign @shreekarSS

harshad16 commented 2 years ago

@mayaCostantini can you please give @shreekarSS some context and getting start help regarding this. please also evaluate the story point and assign it on the issue title.

mayaCostantini commented 2 years ago

@harshad16 sure :+1:

shreekarSS commented 2 years ago
Endpoint Errors Issue
List thoth contaner image Invalid data https://github.com/thoth-station/user-api/issues/1780
List_python_packages Data not available https://github.com/thoth-station/user-api/issues/1782
get_python_package_dependencies Data not available https://github.com/thoth-station/user-api/issues/1783
list_python_package_versions Data not available https://github.com/thoth-station/user-api/issues/1784
get_python_package_version_metadata Timeout https://github.com/thoth-station/user-api/issues/1771
harshad16 commented 2 years ago

@shreekarSS Can please edit your comment into a table for ease of understanding. https://www.markdownguide.org/extended-syntax/#tables

For Example:

Endpoint Errors Issue
PythonPackages/get_python_package_version_metadata Timeout https://github.com/thoth-station/user-api/issues/1771
goern commented 2 years ago

noice tracker issue this is! thanks for keeping all the data together. is there any movement on the references issues? what do we need to get them fixed?

shreekarSS commented 2 years ago

noice tracker issue this is! thanks for keeping all the data together. is there any movement on the references issues? what do we need to get them fixed?

I've assigned these trackers for myself and started work on https://github.com/thoth-station/user-api/issues/1780

goern commented 2 years ago

any update on this?

shreekarSS commented 2 years ago

any update on this?

I have some issue with testing apis in the local env. @harshad16 and I are working on that.

shreekarSS commented 2 years ago

Endpoint Errors Issue List thoth contaner image Invalid data #1780 List_python_packages Data not available #1782 get_python_package_dependencies Data not available #1783 list_python_package_versions Data not available #1784 get_python_package_version_metadata Timeout #1771

All these issues have been fixed , so closing this issue.

mayaCostantini commented 2 years ago

Closing as fixed by @shreekarSS