search

thoth-station / user-api

Web Service exposing Thoth functions to the RESTful worlds
https://thoth-station.github.io/
GNU General Public License v3.0
8 stars 18 forks source link

removed 404 error on list query #1840

Closed Gkrumbach07 closed 1 year ago

Gkrumbach07 commented 1 year ago

Related Issues and Dependencies

fixes https://github.com/thoth-station/thamos/issues/1184

This introduces a breaking change

This Pull Request implements

removed 404 error for container images

Description

I removed the 404 error from /container-images as it is best practice to return 200 on an empty query to a list of data. 404 would indicate that the actual resource does not exist. Resource can be interpreted as either the api endpoint or the table of container images. In both cases the response should still be 200 as the route completed successfully without error, just that there was notting to return.

goern commented 1 year ago

/approve

sesheta commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: goern

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/thoth-station/user-api/blob/master/OWNERS)~~ [goern] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment