threshold-network / merkle-distribution

Threshold Network rewards generation and distribution
https://threshold.network
1 stars 6 forks source link

Jan 1st 24 distribution miscalculation: legacy Nu stakes #120

Closed manumonti closed 8 months ago

manumonti commented 9 months ago

A miscalculation in the Jan 1st distribution has been detected.

Context

At 2023-11-22T04:06:11.000Z the support of legacy Keep and Nu staking was dropped as announced in TIP-063. This date is the start of the transition process, where stakes with legacy staking can migrate their legacy tokens (Keep & Nu) to Threshold Network tokens (T). This process is described in the Transition Guide.

During the transition period, the release of rewards for legacy stakes has been frozen since these are eligible for rewards depending on whether they complete the migration on time.

On Dec 8th, the migration period for legacy Nu stakes ended, so on Jan 1st 2024 distribution, the rewards associated with legacy Nu stakes were released.

It is worth noting that the staking rewards have two sources: tBTC rewards and PRE/TACo rewards.

The issue

Due to a bug in the rewards calculation script, the tBTC part of the rewards for stakes with legacy Nu were not released. This miscalculation affects 20 stakes.

The list of affected stakes is the following (staking provider addresses):

0x25d9bbb4eccbf3a5e6d6bbce9813302e508f321d
0x378c89b5b93667a005856822e1b65e2d7c076373
0x456d643cd97b058fd3bbbeb76f04b1de3679bc6a
0x56c968857ef4919c67d151b56e7073065994c97a
0x700277deaf138c6af9b3177f83918b6a3544f27f
0x83237ba2b7d0bf23090196fccbfb2be1ef21580d
0x8d0b183b68cc93b9f9e1490c85b4a4965ef5cd3b
0x8d34285c047d5d8757551baa45e471e62e72f468
0x9919c9f5cbbaa42cb3bea153e14e16f85fea5b5d
0xa2e44666bab3ed3be4f87b7c18ed2ffb911c0bef
0xa829c2e33907ab03d27d5dbb39effd8386112789
0xb70c8d55d397aa5d76f96c64b3e4084db95c739e
0xc82bed104c3d5785fecebf906e5b1747a1bce681
0xcd087a44ed8ee2ace79f497c803005ff79a64a94
0xce4407df6ae8a92eb69412bd6a8ec49a9b9b40dd
0xd0908b1e0f6e64e3097c663bf95e2e9c040dd40d
0xd680b01503cf95a489010da7409980060991d096
0xd6edf0bc0c19f87ecef67632bfcd212ce8324ab9
0xf9283ac13aec8a2b60a56a82f1f5e4da1742ccf8
0xfd771e3e34a93e19caad4c11c3be16c70d5ec2fd

The fix

The remaining rewards will be distributed in future rewards distributions.