search

threshold-network / merkle-distribution

Threshold Network rewards generation and distribution
https://threshold.network
1 stars 6 forks source link

Use BigNumber library instead of Integers in tests #19

Closed manumonti closed 1 year ago

manumonti commented 2 years ago

In my opinion it would be preferable to use BigNumber library instead of Integers for tokens amounts since these numbers easily exceeds the maximum value of Integers.

https://github.com/MikeMcl/bignumber.js/

_Originally posted by @manumonti in https://github.com/threshold-network/merkle-distribution/pull/13#discussion_r916793381_

manumonti commented 1 year ago

Closing this since Javascript Number max value should be big enough:

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/MAX_VALUE#:~:text=The%20MAX_VALUE%20property%20has%20a,will%20lose%20their%20actual%20value.