search

threshold-network / merkle-distribution

Threshold Network rewards generation and distribution
https://threshold.network
1 stars 6 forks source link

Add JSON with historical cumulative distributions #57

Closed manumonti closed 1 year ago

manumonti commented 1 year ago

Adding a JSON file with historical data about the total cumulative of T rewards generated on each Merkle distribution facilitates the data collection and processing.

This file just collects the data already included on each distribution folder.

derekpierre commented 1 year ago

File looks great!

I don't see any changes to a script/new script. Is this file generated as part of the merkle distribution script i.e. it will automatically get updated for every distribution? (this was your original idea @manumonti )

manumonti commented 1 year ago

File looks great!

I don't see any changes to a script/new script. Is this file generated as part of the merkle distribution script i.e. it will automatically get updated for every distribution? (this was your original idea @manumonti )

Right! Actually, this is a WIP (I forgot to mark the PR as WIP). But we can merge if you need this file ASAP.

derekpierre commented 1 year ago

Ah. Not trying to rush you. This is not needed ASAP. The actual distribution of rewards is definitely more important.

Didn't realize it was WIP 👍

derekpierre commented 1 year ago

PS. thanks for your efforts on getting this started 🎸

manumonti commented 1 year ago

@derekpierre I made a change in the distributions.json.

Is it Ok from your side to store the numbers as String type? Using Number type in JSON causes the numbers to be stored in Scientific Notation when stringifying the JSON using the new script.

derekpierre commented 1 year ago

@derekpierre I made a change in the distributions.json.

Is it Ok from your side to store the numbers as String type? Using Number type in JSON causes the numbers to be stored in Scientific Notation when stringifying the JSON using the new script.

I guess the same string format is done for MerkleDist.json files anyway - so that's fine by me; good to stay consistent. Whatever is simplest for you.