search

threshold-network / merkle-distribution

Threshold Network rewards generation and distribution
https://threshold.network
1 stars 6 forks source link

Eligible number of build versions #89

Closed dimpar closed 10 months ago

dimpar commented 11 months ago

For simplicity purposes, we supported only 2 keep client release tags in a given interval. In rare cases when we need to release a hotfix it might happen that in a given interval 3 keep client versions will be eligible, just like for October 2023 interval. This PR adds support for a third release. However, the default number of tags should be set to 2, only in rare cases the number should be bumped up to 3, i.e. when 3 tags are eligible to run in a given interval.

Important! After the October interval rewards are calculated, the ELIGIBLE_NUMBER_OF_TAGS should be changed to 2

TODO:

Also, this PR includes a cleanup of the Oct 17 2023 case. This scenario is no longer needed to be supported by these scripts.

lukasz-zimnoch commented 10 months ago

I think we should update ALLOWED_UPGRADE_DELAY before merging. I'll take care of it since I'm replacing @dimpar on the rewards support front.

manumonti commented 10 months ago

I think we should update ALLOWED_UPGRADE_DELAY before merging. I'll take care of it since I'm replacing @dimpar on the rewards support front.

I think we can address this update on ALLOWED_UPGRADE_DELAY in the following PR.