Closed manumonti closed 2 years ago
All looks good, we might want to look at adding a github workflow for some of the linting as well, just to make sure that's it's being enforced. Not a blocker for now though.
Looks good! 👍 Left a few comments to look at.
Let's add
.git-blame-ignore-revs
file to ignore bulk changes. Please see https://www.moxio.com/blog/43/ignoring-bulk-change-commits-with-git-blame. Unfortunately, it requires adding bulk change commits manually to the.git-blame-ignore-revs
file but I believe ignoring bulk changes it's a good practice.
@r-czajkowski
Sure! I'm planning to make a new PR formatting the code with the new style once this PR is merged. There we can add .git-blame-ignore-revs
file.
Thank you for the link! I have no idea about that was possible. 👍
I pushed some new commits with these changes:
git commit
, only prettier is run. When git push
, prettier and eslint are run. This allows us to commit locally incomplete contributions, but only complete contributions (without errors) can be pushed to the remote repo.prettier
and eslint
independently.I've added lint-staged and modified package scripts. @r-czajkowski can you check if you agree with this strategy?
To standardize the code format and increase the code robustness, it's necessary to incorporate
subgraph
repo standard development guidelines.The proposed tools are Prettier and ESLint:
contributing
field.This is not a final decision about linting. Feel free to suggest prettier/linting rules. 😄