search

threshold-network / staking-subgraphs

Threshold Network staking subgraphs
https://threshold.network
1 stars 1 forks source link

Format code following new code style guidelines #15

Closed manumonti closed 2 years ago

manumonti commented 2 years ago

This PR should be reviewed and merged after #14

Since new linting tools have been introduced in this repo (i.e Prettier and ESLint), the existing code must be adapted to this new format.

Note: To add a .git-blame-ignore-revs-file has been considered. But since the changes only strongly affect one file (docker-compose.yaml), IMHO adding a new file to the repo may be confusing and the benefits don't worth it.

What do you think, @r-czajkowski ?

r-czajkowski commented 2 years ago

Note: To add a .git-blame-ignore-revs-file has been considered. But since the changes only strongly affect one file (docker-compose.yaml), IMHO adding a new file to the repo may be confusing and the benefits don't worth it.

Nevertheless, I prefer to add this file. It may be useful for the future when someone pushes changes with -n flag 😆. Also, there are still a few changes that were made with the formatting tools, so it's always better to skip these commits. It also doesn't take much work it's just one file with one line (at least for now).

manumonti commented 2 years ago

Done! Ready to review @r-czajkowski .