thunder-app / thunder

Thunder - An open-source cross-platform Lemmy client for iOS and Android built with Flutter
https://thunderapp.dev
GNU Affero General Public License v3.0
712 stars 62 forks source link

Fix showing deleted comments #1303

Closed micahmo closed 1 month ago

micahmo commented 1 month ago

Pull Request Description

This PR fixes an issue where the contents of deleted comments can appear in some places (i.e., user profile). The cleaning code has been applied directly to the CommentContent widget so it automatically gets applied everywhere (rather than having to remember to do it in every different type of bloc).

While doing some refactoring, I came across this widget which does not appear to be used anywhere. Is it safe to deleted?

https://github.com/thunder-app/thunder/blob/develop/lib/user/widgets/comment_card.dart

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before

https://github.com/thunder-app/thunder/assets/7417301/cb062bd8-924e-498e-9584-67243a37972f

After

https://github.com/thunder-app/thunder/assets/7417301/c0aadb9d-34b1-4d59-b442-b18b8113a24f

Checklist

hjiangsu commented 1 month ago

Is it safe to deleted?

It looks like we can delete it - I'm assuming this was left over from the comment refactor a while back! Nice catch 😄

micahmo commented 1 month ago

Ok deleted!