thunder-app / thunder

Thunder - An open-source cross-platform Lemmy client for iOS and Android built with Flutter
https://thunderapp.dev
GNU Affero General Public License v3.0
712 stars 62 forks source link

Implement search functionality in more areas of the app #1306

Open codenyte opened 1 month ago

codenyte commented 1 month ago

Is Your Feature Request Related to a Problem?

No response

Feature Description

There are some areas of the app that could really benefit from a search feature. Examples of this are:

Alternative Solutions

N/A

Additional Context

I wasn't sure whether to combine these into one issue or to open seperate issues for the search functionality in the individual areas of the app

micahmo commented 1 month ago

Hey @codenyte, thanks for the issue! I think it's ok to have all of these in one. Maybe we can make them into checkboxes in your original post so we can check them off as they're done.

  • search feature in the comment section

I believe this was implemented in #887! Take a look at the video (or try yourself) and let me know if that's what you had in mind!

codenyte commented 1 month ago

Damn, I did not realize that this feature exists. It's kinda hidden away, maybe add an option to display a search box at the top of the comment page, similar to Apollo? Is this worth considering?

Edit: It's even more confusing, because I don't see the three dots as can be seen in your screen recording, but instead, I see a reply button. The search button is only revealed when long pressing on the reply button. I find this to be pretty confusing, I don't think I would have ever found this myself.

micahmo commented 1 month ago

maybe add an option to display a search box at the top of the comment page, similar to Apollo? Is this worth considering?

Sure, we can definitely try to make it more visible! Do you think it would be visible enough if it were in the overflow menu (three dots) at the top?

I don't see the three dots as can be seen in your screen recording, but instead, I see a reply button. The search button is only revealed when long pressing on the reply button.

Ahh, that's due to the FAB settings. I believe the default is to reply on single press and show the additional options on long press or swipe up. I have mine set to show additional options on single press (hence the three dots). It provides more visibility, but it also removes the ability to perform a single action without multiple taps. The nice thing is that the FAB is super customizable. You can even have separate actions for short and long press, and still access all the additional items with a swipe. Try messing around with these settings! 😊

image
codenyte commented 1 month ago

Thanks a lot! I now have the Floating Action Button set to work as a search button. For some reason, it doesn't work though. It appears to be a bug? I tap on the FAB (which now has a search icon) and nothing happens. I can only bring up the search by swiping up from the FAB and selecting Search from the menu. Will add a screen recording later.

micahmo commented 1 month ago

Wow, nice catch! No need for a video as I can reproduce. Thanks!