Fix issue with search from FAB - Githubissues

thunder-app / thunder

Thunder - An open-source cross-platform Lemmy client for iOS and Android built with Flutter

https://thunderapp.dev

GNU Affero General Public License v3.0

712 stars 62 forks source link

Fix issue with search from FAB #1308

Closed micahmo closed 1 month ago

micahmo commented 1 month ago

Pull Request Description

This PR fixes an issue where the comment search function could not be invoked if it were the primary (single press) FAB button.

Issue Being Fixed

Issue Number: See https://github.com/thunder-app/thunder/issues/1306#issuecomment-2059377220

Screenshots / Recordings

https://github.com/thunder-app/thunder/assets/7417301/15dbce79-0830-4842-88fe-28de23ec2230

Checklist

[ ] Did you update CHANGELOG.md?
[ ] Did you use localized strings where applicable?
[ ] Did you add semanticLabels where applicable for accessibility?

micahmo commented 1 month ago

I would like to eventually refactor our handling of override actions (it's getting a bit complicated 😅)

Totally agreed, that's exactly why this got missed.